Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps optimization at build time did not tree-shaking #14106

Closed
7 tasks done
windsonR opened this issue Aug 15, 2023 · 1 comment · Fixed by #15184
Closed
7 tasks done

Deps optimization at build time did not tree-shaking #14106

windsonR opened this issue Aug 15, 2023 · 1 comment · Fixed by #15184
Labels
feat: build feat: deps optimizer Esbuild Dependencies Optimization

Comments

@windsonR
Copy link
Contributor

windsonR commented Aug 15, 2023

Describe the bug

When i using deps optimization at build time, looks like it was not tree-shaking

Reproduction

https://github.com/windsonR/my-vue-app

Steps to reproduce

In reproduction, i use ant-design-vue to reproduce this.

Run pnpm install then pnpm build

Then, in dist/index.*.js search AInput or ATable

System Info

System:
    OS: macOS 13.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 92.09 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.2 - ~/.n/bin/node
    Yarn: 1.22.19 - ~/.n/bin/yarn
    npm: 9.8.1 - ~/.n/bin/npm
    pnpm: 8.6.10 - ~/.n/bin/pnpm
  Browsers:
    Firefox Nightly: 118.0a1
    Safari: 16.6
  npmPackages:
    @vitejs/plugin-vue2: ^2.2.0 => 2.2.0 
    vite: ^4.4.5 => 4.4.5

Used Package Manager

pnpm

Logs

No response

Validations

@patak-dev patak-dev added feat: deps optimizer Esbuild Dependencies Optimization feat: build and removed pending triage labels Aug 15, 2023
@Plumbiu
Copy link
Contributor

Plumbiu commented Sep 9, 2023

I see rollup and esbuild don't tree-shaking either, may be this issue is not related to vite.

a fork with rollup and esbuild

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: build feat: deps optimizer Esbuild Dependencies Optimization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants