Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): correctly display the config file name #14160

Merged
merged 3 commits into from Aug 21, 2023
Merged

fix(client): correctly display the config file name #14160

merged 3 commits into from Aug 21, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Aug 19, 2023

Description

Correctly display configuration file suffix information.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Aug 21, 2023
@btea btea changed the title fix(client): correct the file suffix message of overlay error fix(client): correctly display the config file name Aug 21, 2023
@btea @bluwy
Update packages/vite/src/node/plugins/clientInjections.ts
65ff263 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy bluwy merged commit 61e801d into vitejs:main Aug 21, 2023
11 checks passed
@btea btea deleted the fix/overlay-correct-message branch August 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@btea @bluwy