Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): fix broken build when renderModernChunks=false & polyfills=false (fix #14324) #14346

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix(legacy): fix broken build when renderModernChunks=false & polyfills=false (fix #14324) #14346

merged 2 commits into from
Sep 26, 2023

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Sep 10, 2023

Closes #14324

Description

Issue #14324 has a detailed explaination of the bug. In short, if the legacy plugin is configured with renderModernChunks=false & polyfills=false then the outputted build is broken and unusable.

This PR fixes the bug by including the ployfill chunk in this scenario, since the ployfill chunk contains SystemJS.

Additional context

I'm not sure how to add tests without creating an entirely new folder under /playground, since a test for this PR would require a different vite.config.ts file.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

packages/plugin-legacy/src/index.ts Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) labels Sep 15, 2023
sapphi-red
sapphi-red previously approved these changes Sep 25, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k-yle
Copy link
Contributor Author

k-yle commented Sep 26, 2023

I don't think the test failure in playground/assets is related to this PR...

@sapphi-red sapphi-red merged commit 27e5b11 into vitejs:main Sep 26, 2023
10 checks passed
@k-yle k-yle deleted the 14324-legacy-bundle-broken branch September 26, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy plugin produces broken build with renderModernChunks=false & polyfills=false
3 participants