Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): suppress babel warning during polyfill scan #14425

Merged
merged 1 commit into from Sep 21, 2023

Conversation

kingyue737
Copy link
Contributor

Description

Babel throws the following warning during building which is quite annoying:

[BABEL] Note: The code generator has deoptimised the styling of undefined as it exceeds the max of 500KB.

I think we can simply turn on compact option when detecting polyfills. Just like what Evan previous did in 045e519

fixes #7907

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added plugin: legacy p2-nice-to-have Not breaking anything but nice to have (priority) labels Sep 21, 2023
@sapphi-red sapphi-red changed the title fix(plugin-legacy): suppress babel warning during polyfill scan fix(legacy): suppress babel warning during polyfill scan Sep 21, 2023
@bluwy bluwy merged commit aae3a83 into vitejs:main Sep 21, 2023
11 checks passed
@kingyue737 kingyue737 deleted the patch-1 branch September 21, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BABEL] Note: The code generator has deoptimised the styling of undefined as it exceeds the max of 500KB.
3 participants