Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generateCodeFrame infinite loop #15093

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 22, 2023

Description

fixes #15076
refs #14984

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Nov 22, 2023
Comment on lines +509 to +512
end = Math.min(
end !== undefined ? posToNumber(source, end) : start,
source.length,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? {
line: warning.endLine,
column: warning.endColumn - 1, // 1-based
}

{ endLine: 107, endColumn: 2 } was passed here. So posToNumber(source, { line: 107, column: 1 }) was called.
But the source only has 107 lines. So posToNumber returned a number greater than source.length.

@patak-dev patak-dev merged commit 6619de7 into vitejs:main Nov 22, 2023
11 checks passed
@sapphi-red sapphi-red deleted the fix/generate-code-frame-infinite-loop branch November 22, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated CSS that creates warnings can cause infinite loops in generateCodeFrame
2 participants