Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-legacy: syntax error in variable detectModernBrowserCode #15094

Closed
7 tasks done
jiadesen opened this issue Nov 22, 2023 · 0 comments · Fixed by #15095
Closed
7 tasks done

plugin-legacy: syntax error in variable detectModernBrowserCode #15094

jiadesen opened this issue Nov 22, 2023 · 0 comments · Fixed by #15095
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) plugin: legacy

Comments

@jiadesen
Copy link
Contributor

Describe the bug

There is a lack of ; before if in the variable detectModernBrowserCode, which causes legacy resources to be loaded incorrectly in the ESM environment.

Reproduction

Steps to reproduce

No response

System Info

-

Used Package Manager

pnpm

Logs

No response

Validations

@jiadesen jiadesen changed the title syntax error in variable detectModernBrowserCode plugin-legacy: syntax error in variable detectModernBrowserCode Nov 22, 2023
@sapphi-red sapphi-red added plugin: legacy p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) labels Nov 22, 2023
@titenis titenis mentioned this issue Nov 22, 2023
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) plugin: legacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants