Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): Allow RegEx as server.proxy keys #1510

Merged
merged 6 commits into from Jan 13, 2021
Merged

feat(vite): Allow RegEx as server.proxy keys #1510

merged 6 commits into from Jan 13, 2021

Conversation

timozander
Copy link
Contributor

Implements #1416

Requiring ^ as the beginning of the string is desirable IMO to avoid unnecessary RegEx parsing of all literals

@underfin
Copy link
Member

underfin commented Jan 13, 2021

Maybe it is better if provider one function to resolve that? /cc @yyx990803

@yyx990803
Copy link
Member

@underfin function would require the proxy option to be in a different shape though. I think allowing regex makes sense.

docs/config/index.md Outdated Show resolved Hide resolved
@timozander
Copy link
Contributor Author

timozander commented Jan 13, 2021

Appveyor failed due to yarn 503

@yyx990803 yyx990803 merged commit f39a2aa into vitejs:main Jan 13, 2021
@timozander timozander deleted the feature_proxy_regex branch January 13, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants