Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): set hoistTransitiveImports to false in library builds #15595

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(build): set hoistTransitiveImports to false in library builds #15595

merged 1 commit into from
Jan 15, 2024

Conversation

Kaciras
Copy link
Contributor

@Kaciras Kaciras commented Jan 13, 2024

Description

Rollup has an option hoistTransitiveImports to make chunks load as early as possible by adding empty imports to the entry, but it is useless for libraries:

  • The library will not be the first-loaded module, which makes hoisting useless.
  • Projects may use builders, in which case these extra imports are redundant.

These empty imports have also caused some confusion: rollup/rollup#3332, rollup/rollup#4564

This PR disable hoistTransitiveImports option by default in library build, make the output code more clean.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added feat: library mode p2-nice-to-have Not breaking anything but nice to have (priority) labels Jan 15, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@bluwy bluwy merged commit e6ebc7b into vitejs:main Jan 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: library mode p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants