Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize import file path info #15772

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Feb 1, 2024

Description

image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Feb 1, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed in the codebase we also often do normalizePath(path.relative('...')) instead, I wonder if there's a perf difference.

@btea
Copy link
Collaborator Author

btea commented Feb 2, 2024

Yes, I noticed that too, I just briefly tried it and found that the performance difference between the two is very small. (The environment I tested is win 10, node18.16.1)

I tested it again and found that path.relative cannot be directly replaced with path.posix.relative. Maybe we should still use normalizePath to handle it.

const root = 'D:\\project\\a'
const to = 'D:/prject/a/src/main.ts'
path.relative(root, to) // => src\main.ts
path.posix.relative(root, to) // => ../D:/project/a/src/main.ts

@patak-dev patak-dev merged commit 306df44 into vitejs:main Feb 12, 2024
8 of 10 checks passed
@btea btea deleted the fix/normalize-import-file branch February 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants