Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: judge next dirent cache type #15787

Merged
merged 1 commit into from Feb 6, 2024

Conversation

XiSenao
Copy link
Collaborator

@XiSenao XiSenao commented Feb 2, 2024

Description

fix: #15784

Additional context

If I understand correctly, we need to determine the type of the next Dirent here.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy requested a review from patak-dev February 6, 2024 08:31
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, good catch @XiSenao! Thanks for fixing this!

@patak-dev patak-dev merged commit 5fbeba3 into vitejs:main Feb 6, 2024
9 of 10 checks passed
@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve import. Does the file exist? since 5.1.0-beta.4 (5.1.0-beta.3 was fine)
3 participants