Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(importAnalysis): skip encode in ssr #16213

Merged
merged 1 commit into from Mar 20, 2024
Merged

fix(importAnalysis): skip encode in ssr #16213

merged 1 commit into from Mar 20, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 20, 2024

Description

In SSR, because import specifiers are not needed to be encoded (unlike browsers), we can skip encoding altogether in import analysis. This was the initial issue that causes Nuxt to see two kinds of encoded and non-encoded links, because ssrLoadModule receives an id that we assume to be already un-encoded.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch!

@patak-dev patak-dev enabled auto-merge (squash) March 20, 2024 12:57
@patak-dev patak-dev merged commit e4d2d60 into main Mar 20, 2024
11 checks passed
@patak-dev patak-dev deleted the ssr-no-encode branch March 20, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants