Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): fix optimizeDeps.include glob syntax for ./* exports #16230

Merged
merged 3 commits into from Mar 22, 2024

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Mar 22, 2024

Description

There is a small inconsistency in fast-glob's output, which was making some regex to miss when ./* exports is used and this case was not covered by the current test case @vitejs/test-dep-optimize-exports-with-glob. I made a quick fix to just cover this special case.

I wrote in the comment, but the inconsistency can be replayed like this:

$ cd packages/vite
$ node -p 'require("fast-glob").sync("./*")'
[
  'CHANGELOG.md', // <-- not './CHANGELOG.md'
  'LICENSE.md',
  ...
]
$ node -p 'require("fast-glob").sync("./types/*")'
[
  './types/customEvent.d.ts',
  './types/hmrPayload.d.ts',
  ...
]

I quickly skimmed through fast-glob side, but I didn't find any special call out about this behavior. Vite side fix seems simple enough, so I went with this, but please let me know if you want to check with fast-glob further.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 22, 2024 09:20
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 22, 2024
@bluwy bluwy merged commit f184c80 into vitejs:main Mar 22, 2024
9 of 10 checks passed
@hi-ogawa hi-ogawa deleted the fix-optimizeDeps-include-catchall branch March 23, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globbing in optimizeDeps.includes does not seem to work
2 participants