fix(hmr): don't mutate module graph when collecting modules #16302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p4-important
|
|
sapphi-red
commented
Mar 29, 2024
Comment on lines
+165
to
168
| const mods = new Set(moduleGraph.getModulesByFile(file)) | ||
| if (type === 'create' || type === 'delete') { | ||
| for (const mod of getAffectedGlobModules(file, server)) { | ||
| mods.add(mod) |
There was a problem hiding this comment.
moduleGraph.getModulesByFile(file) returns a Set. mods.add(mod) mutates that Set causing the module graph to have incorrect fileToModulesMap.
patak-dev
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#16288 had a code that breaks the module graph.