Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): unknown file error happened with lightningcss #16306

Merged
merged 3 commits into from Mar 29, 2024
Merged

fix(css): unknown file error happened with lightningcss #16306

merged 3 commits into from Mar 29, 2024
+3 −2

Conversation

sapphi-red
Copy link
Member

Description

The following was happening:

"id".replace('id', '$$') // '$'

fixes #16297

Review PR in StackBlitz Submitted with StackBlitz.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 29, 2024
@patak-dev patak-dev enabled auto-merge (squash) March 29, 2024 09:23
@patak-dev patak-dev merged commit 01af308 into vitejs:main Mar 29, 2024
10 checks passed
@sapphi-red sapphi-red deleted the fix/lightning-css-asset-output-unknown-file branch March 29, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference IDs containing $$ fail to be resolved with LightningCSS
2 participants
@sapphi-red @patak-dev