Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload does not happen if an entrypoint is in a circular dep loop #16664

Open
7 tasks done
alexandermake opened this issue May 13, 2024 · 5 comments
Open
7 tasks done
Labels
feat: hmr p2-edge-case Bug, but has workaround or limited in scope (priority)

Comments

@alexandermake
Copy link

alexandermake commented May 13, 2024

Describe the bug

In the repo,
after change any part of source code, hmr do not refresh the page.

Reproduction

https://github.com/alexandermake/puzzling-potions

Steps to reproduce

npm install
npm run start

System Info

System:
    OS: macOS 14.4.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 1.98 GB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.1 - ~/.nvm/versions/node/v20.12.1/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v20.12.1/bin/npm
  Browsers:
    Chrome: 124.0.6367.158
    Safari: 17.4.1
  npmPackages:
    vite: ^5.2.2 => 5.2.2

Used Package Manager

npm

Logs

No response

Validations

@bluwy
Copy link
Member

bluwy commented May 13, 2024

Copy link

Hello @alexandermake. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs reproduction will be closed if they have no activity within 3 days.

@alexandermake
Copy link
Author

Here is it link

@sapphi-red
Copy link
Member

Trimmed down repro: https://stackblitz.com/edit/vitejs-vite-lnwjz8?file=main.js&terminal=dev
It seems the reload doesn't happen if the entry is in a circular dep loop.

@sapphi-red sapphi-red added feat: hmr p2-edge-case Bug, but has workaround or limited in scope (priority) labels May 17, 2024
@sapphi-red sapphi-red changed the title HMR not working Reload does not happen if an entrypoint is in a circular dep loop May 17, 2024
@bluwy
Copy link
Member

bluwy commented May 17, 2024

Seems to be related to #15585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

No branches or pull requests

3 participants