Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust import analysis behavior to match Node #16738

Merged
merged 1 commit into from
May 29, 2024

Conversation

stenin-nikita
Copy link
Contributor

Description

fixes #16714


Review PR in StackBlitz Submitted with StackBlitz.

Copy link

stackblitz bot commented May 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member

bluwy commented May 28, 2024

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels May 28, 2024
@bluwy bluwy added this to the 5.3 milestone May 28, 2024
@bluwy
Copy link
Member

bluwy commented May 28, 2024

It's a bit hard to tell what failed in Vike, but I think it should be fine.

@bluwy
Copy link
Member

bluwy commented May 29, 2024

/ecosystem-ci run vike

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on faa197d: Open

suite result latest scheduled
vike failure failure

@bluwy bluwy merged commit f599ab4 into vitejs:main May 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The proxyGuardOnlyEsm does not work consistently
2 participants