Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR path customization ignored #1705

Closed
3 tasks done
gryphonmyers opened this issue Jan 25, 2021 · 4 comments
Closed
3 tasks done

HMR path customization ignored #1705

gryphonmyers opened this issue Jan 25, 2021 · 4 comments

Comments

@gryphonmyers
Copy link

gryphonmyers commented Jan 25, 2021

⚠️ IMPORTANT ⚠️ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

  • Read the docs.
  • Use Vite >=2.0. (1.x is no longer supported)
  • If the issue is related to 1.x -> 2.0 upgrade, read the Migration Guide first.

Describe the bug

Specifying config.server.hmr.path per documentation at https://vitejs.dev/config/#server-hmr does not result in the WS being opened at the specified path.

Reproduction

https://github.com/gryphonmyers/vite-minimal-repro/tree/hmr-path

(Note that the ws request is opened at localhost:3000 and not localhost:3000/foobar)

System Info

  • vite version: 2.0.0-beta.48
  • Operating System: macos 10.15.1
  • Node version: 14.15.1
  • Package manager (npm/yarn/pnpm) and version: 6.14.8
@Priestch
Copy link
Contributor

@gryphonmyers You may remove the / before footbar to get the expected result.
The document should be more clear about this.

@gryphonmyers
Copy link
Author

@Priestch @yyx990803 I'm sorry but it doesn't work without the leading slash either (I had tried that before submitting). BTW this is a regression since beta35

@yyx990803
Copy link
Member

It was closed by a commit. Try upgrading to the latest release.

@gryphonmyers
Copy link
Author

Thanks! Sorry I should have checked the commit :)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants