fix: allow ssr css preloads in preload-helper #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this bug while I was experimenting with preloading css that I know would end up being loaded during app execution.
In my app, I know various components that my page is going to load ahead of time, so I use the manifest.json to inject
link[rel=modulepreload/preload][as=script/style]preloads in<head>before delivering it to the browser that I know will be loaded later on.In built index.html file, if you add css preloads for the same href as the app is going to load, the app does not append link[rel="stylesheet"] to the document. This is due to a conditional in importAnaysisBuild
Example:
During app page execution, the following should have been appended to the document head, but was not:
This PR fixes this issue and also includes some performance improvements to the surrounding logic.