fix: dependency scan with esbuild when using non-HTML entrypoints #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
force-pushed
the
fix-multi-entry-dep-scan
branch
from
c7ff56f
to
2770d60
Compare
|
Fixed type + more assets/css edge case handling, waiting on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 馃摉
This pull request is an attempt to fix #1763.
By passing
entriesto theesbuildScanPlugin, we are able to avoid passingexternal: truetoesbuild.This change needs to be reviewed to assess the potential impact of the change.
Dependencies in the entrypoints, such as
vue, seem to be correctly detected and optimized, but I might be missing some corner cases.Background 馃摐
After
beta.51introduced an esbuild-based dependency scan, projects with non-HTML entrypoints started to fail with an esbuild error:cannot be marked as externalbuildworks as expected inbeta.51for multiple non-HTML entrypoints, so it's only the dependency scanning that suffers this problem.Reproduction 馃悶
The issue can be replicated in this application, by running
pnpm installandpnpm dev.