Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): do not open browser when restarting server #1952

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(hmr): do not open browser when restarting server #1952

merged 1 commit into from
Feb 9, 2021

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented Feb 9, 2021

Update the config file will open browser every time when using config.server.open

@yyx990803 yyx990803 merged commit 9af1517 into vitejs:main Feb 9, 2021
@CHOYSEN CHOYSEN deleted the patch3 branch February 9, 2021 14:52
@ghost ghost mentioned this pull request Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Also, there's a new vite preview command

"scripts": {
    "serve": "vite preview",
  },

and it doesn't open a browser with

// vite.config.js
export default {
  server: {
    open: true
  }
}

@yunsii
Copy link

yunsii commented Feb 21, 2021

@web2033 Hi, still can't open browser with server.open?

@ghost
Copy link

ghost commented Feb 21, 2021

@theprimone it's working fine since #1968

@yunsii
Copy link

yunsii commented Feb 21, 2021

@web2033 I develop in WSL with server.open: true, when I run vite, the browser is not open. Something wrong in WSL?

@ghost
Copy link

ghost commented Feb 21, 2021

Maybe there are some specifics related to WSL. Sorry, can't say, I don't use it.

@yunsii
Copy link

yunsii commented Feb 21, 2021

Still thanks, I will retry on macOS tomorrow _(:3J∠)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants