Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get the unescaped string from lexer correctly #2162

Merged
merged 4 commits into from
Feb 24, 2021
Merged

fix: get the unescaped string from lexer correctly #2162

merged 4 commits into from
Feb 24, 2021

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented Feb 22, 2021

Fix #2083

@CHOYSEN
Copy link
Contributor Author

CHOYSEN commented Feb 22, 2021

@types/es-module-lexer has not been updated yet

@yyx990803
Copy link
Member

Can you add @ts-ignore to fix the type issue for now?

@jonaskuske
Copy link
Contributor

Where should I add this tag?

Always on the line before you do imports[index].n, e.g.

// @ts-ignore
const url = imports[index].n ?? code.slice(start, end)

@CHOYSEN CHOYSEN marked this pull request as draft February 23, 2021 08:15
@CHOYSEN
Copy link
Contributor Author

CHOYSEN commented Feb 23, 2021

@jonaskuske thanks, there was something wrong with my environment before

@CHOYSEN CHOYSEN marked this pull request as ready for review February 23, 2021 16:23
@CHOYSEN CHOYSEN changed the title fix: get the correct escape sequences from lexer fix: get the unescaped string from lexer correctly Feb 23, 2021
@yyx990803 yyx990803 merged commit bbda31e into vitejs:main Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to resolve import with unicode path in typescript
3 participants
@CHOYSEN @yyx990803 @jonaskuske