Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx: Improve how @fs urls are printed #2362

Merged
merged 2 commits into from
Mar 6, 2021
Merged

dx: Improve how @fs urls are printed #2362

merged 2 commits into from
Mar 6, 2021

Conversation

ElMassimo
Copy link
Contributor

@ElMassimo ElMassimo commented Mar 3, 2021 •
edited
Loading

Description 📖

This pull request changes the way @fs paths are processed by prettifyUrl.

Before

Prior to these changes, @fs URLs were incorrectly printed if they were absolute paths:

vite:load 0ms   [fs] ../../../Projects/pingcrm-vite/app/javascript/Shared/SelectInput.vue +10ms
vite:transform 6ms   ../../../Projects/pingcrm-vite/app/javascript/Shared/SelectInput.vue +11ms
vite:time 9ms   ../../../Projects/pingcrm-vite/app/javascript/Shared/SelectInput.vue +11ms

After

Now @fs paths are printed relative to the root:

vite:load 0ms   [fs] ../Shared/SelectInput.vue +14s
vite:transform 14ms  ../Shared/SelectInput.vue +14s
vite:time 16ms  ../Shared/SelectInput.vue +14s

@ElMassimo ElMassimo marked this pull request as draft March 3, 2021 20:45
@ElMassimo ElMassimo marked this pull request as ready for review March 3, 2021 20:52
@underfin underfin merged commit 5d4e82d into vitejs:main Mar 6, 2021
@ElMassimo ElMassimo deleted the improve-prettify-url branch March 6, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElMassimo @underfin