fix(hmr): never invalidate an accepting importer #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2021
Closed
Closed
This was referenced Mar 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A module that uses
hot.acceptfor a dependency should not be invalidated when that dependency is hot-reloaded. Otherwise, the accepting module will be reloaded by its own importers (but only when an importer is reloaded), which is both unnecessary and unexpected.This behavior led to a bug in a PR to
vite-plugin-react-pageswhere HMR updates to a virtual module are merged intelligently to avoid a full page reload. vitejs/vite-plugin-react-pages#11