Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): support keepNames option for optimizeDeps config #2742

Merged
merged 1 commit into from
Mar 29, 2021
Merged

feat(dev): support keepNames option for optimizeDeps config #2742

merged 1 commit into from
Mar 29, 2021

Conversation

itsthekeming
Copy link
Contributor

@itsthekeming itsthekeming commented Mar 28, 2021

Description

Fixes the undesired behavior detailed in this comment on #2376 by reverting to the original approach of using an option instead of forcing keepNames to true.

Additional Context

This PR is practically identical to #2376 except that I added a default value to the docs as suggested by @patak-js here.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added bug p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 28, 2021
@patak-dev patak-dev merged commit 130bf5a into vitejs:main Mar 29, 2021
@itsthekeming itsthekeming deleted the keep-names-option branch March 29, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants