Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace __dirname and __filename in config file #2780

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix: replace __dirname and __filename in config file #2780

merged 1 commit into from
Mar 30, 2021

Conversation

egoist
Copy link
Contributor

@egoist egoist commented Mar 30, 2021

Description

Fix #2728

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-requested a review March 30, 2021 10:09
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 30, 2021
@patak-dev patak-dev merged commit eb57ac6 into vitejs:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__dirname inside plugins always points to vite.config.ts directory
3 participants
@egoist @patak-dev @Shinigami92