Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A static and dynamically imported module is loaded twice #2935

Merged
merged 7 commits into from
Apr 13, 2021

Conversation

rpetersen27
Copy link
Contributor

Description

If you have one static import of a module (e.g. import foo from './foo') and another dynamic import of the same module (e.g. const v = 'foo; import('./${v}.js')), the first import is used as is, but the second will have a ?import appended. Therefore, the browser interprets them as two different modules.

This PR introduces a fix where the dynamic import is analyzed and only appends the "import" suffix if necessary.

Additional context

This only affected the vite-dev-server, production build worked fine.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-requested a review April 10, 2021 12:41
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 10, 2021
Shinigami92
Shinigami92 previously approved these changes Apr 12, 2021
packages/vite/src/node/plugins/importAnalysis.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev merged commit 266fb55 into vitejs:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants