Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't resolve import using browser during SSR (fix #2995) #2996

Merged
merged 1 commit into from Apr 15, 2021

Conversation

benmccann
Copy link
Collaborator

Description

The browser field should not be resolved for SSR

Additional context

Closes #2995

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 15, 2021
@patak-dev patak-dev merged commit fd1c9ba into vitejs:main Apr 15, 2021
@ixxie
Copy link

ixxie commented Apr 15, 2021

Thanks for merging this rapidly; when can I expect this to be released, more or less?

@Shinigami92
Copy link
Member

Mostly the next upcoming weekend, but don't pin me on that 🙂

@ixxie
Copy link

ixxie commented Apr 15, 2021

Cheers @Shinigami92, I'll keep my eyes peeled :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite resolves import with browser field during SSR
4 participants