Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await bundle close in worker plugin #2997

Merged
merged 1 commit into from
Apr 25, 2021
Merged

fix: await bundle close in worker plugin #2997

merged 1 commit into from
Apr 25, 2021

Conversation

hannoeru
Copy link
Sponsor Contributor

Description

bundle.close() is return Promise so we need to make sure it will be execute in the right timing.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hannoeru hannoeru mentioned this pull request Apr 15, 2021
Closed
9 tasks
patak-dev
patak-dev previously approved these changes Apr 15, 2021
View reviewed changes
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 15, 2021
@Shinigami92 Shinigami92 self-requested a review April 15, 2021 07:16
@Shinigami92
Copy link
Member

Shinigami92 commented Apr 25, 2021 •
edited
Loading

@hannoeru We had some fixes for the memory issues in our tests
Could you please update your PR to the latest main?

@hannoeru
Copy link
Sponsor Contributor Author

@Shinigami92 Done

@patak-dev patak-dev merged commit 0e7125a into vitejs:main Apr 25, 2021
@hannoeru hannoeru deleted the fix/await-bundle-close-1 branch April 29, 2021 03:05
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@hannoeru @TobiasMelen
fix: await bundle close in worker plugin (vitejs#2997)
46a464e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannoeru @Shinigami92 @patak-dev