Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add .module.pcss typings (#3518) #3519

Merged
merged 1 commit into from
May 24, 2021
Merged

fix(types): add .module.pcss typings (#3518) #3519

merged 1 commit into from
May 24, 2021

Conversation

edikdeisling
Copy link
Contributor

@edikdeisling edikdeisling commented May 24, 2021 •
edited
Loading

Description

fixes #3518

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 24, 2021
@patak-dev patak-dev merged commit 3475351 into vitejs:main May 24, 2021
@edikdeisling edikdeisling deleted the pcss-typings branch May 24, 2021 10:39
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
@edikdeisling @ygj6
fix(types): add .module.pcss typings, fix vitejs#3518 (vitejs#3519)
046fde2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS typings error with .module.pcss extension
3 participants
@edikdeisling @patak-dev @Shinigami92