Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assetImportMetaUrl): prevent mixed match result #4482

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

dejour
Copy link
Contributor

@dejour dejour commented Aug 3, 2021

Description

fix #4416, the cause of issue is importMetaUrlRE is shared by multiple transform phase. this pr fix it by using a standalone regex at each transform phase.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dejour dejour changed the title fix(assetImportMetaUrl): prevent mixed matched result fix(assetImportMetaUrl): prevent mixed match result Aug 3, 2021
@patak-dev patak-dev merged commit 86f673a into vitejs:main Aug 3, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite doesn't transform new URL( "/src/assets/") in production build
3 participants