Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html): Inline entry chunk into html when possible #4555

Merged
merged 3 commits into from
Sep 13, 2021
Merged

feat(html): Inline entry chunk into html when possible #4555

merged 3 commits into from
Sep 13, 2021

Conversation

andylizi
Copy link
Contributor

@andylizi andylizi commented Aug 9, 2021

Description

This PR implements the solution described in #4554. Please see over there for details.

Additional context

About possible breakage: I've been doing some testing recently, looking through the plugin list in awesome-vite and such, and I haven't found any plugin that would be affected by this change. As for existing projects, I think most of them probably won't depend on the old behaviour.

Fixes #4554, fixes #3127, closes #3129.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@andylizi andylizi changed the title Inline entry chunk into html when possible feat(html): Inline entry chunk into html when possible Aug 9, 2021
@andylizi andylizi marked this pull request as ready for review August 9, 2021 11:03
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Aug 9, 2021
@Shinigami92
Copy link
Member

On the first look, it's LGTM.
But I'm not into deep technical aspects of this, so I would like to have another person to look deeper into the technical parts.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this feat with the team today and it looks good, and it is great that it also gives Vite Zero JS support. Thanks for this PR @andylizi, I think that @DylanPiercey and the marko team would be very happy to see this merged.

@patak-dev patak-dev added this to the 2.6 milestone Aug 25, 2021
@patak-dev
Copy link
Member

Thanks for implementing this feature @andylizi, we have merged this PR in preparations for vite 2.6-beta

@patak-dev patak-dev merged commit e687d98 into vitejs:main Sep 13, 2021
@andylizi andylizi deleted the html-inline-entry branch September 14, 2021 09:55
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@sun0day sun0day mentioned this pull request Jun 25, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid generating identical entry chunks for every html Support Zero JS™ output in build mode.
4 participants