fix: websocket proxies not the same as http #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Sep 10, 2021
| @@ -116,3 +115,10 @@ export function proxyMiddleware( | |||
| next() | |||
| } | |||
| } | |||
|
|
|||
| function testUrl(url: string, target: string) { | |||
There was a problem hiding this comment.
"test" seems a bit ambiguous here or maybe doesn't describe what this function does that clearly. Is this test as in RegExp.test? Or are these URLs used for testing? Maybe there could be a better name for this function that describes what it's checking for?
There was a problem hiding this comment.
thanks for the quick review, is doesProxyContextMatchUrl ok? 437457d
underfin
approved these changes
Sep 12, 2021
patak-dev
approved these changes
Sep 16, 2021
|
Thanks for the PR @mikeplus64, it would be good if we could get some tests added to the playground in case you see a reliable way to test this and other related functionality |
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently WebSocket proxies cannot use a regex like with HTTP ones -- this PR makes WS and HTTP have the same behaviour for matching URLs. Seems like just something that was missed when initially adding regex support for proxies.
What is the purpose of this pull request?