fix: force overlay LTR #4943
Merged
fix: force overlay LTR #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make overlay window readable in RTL development environment.
|
Could you provide a screenshot? Just for clarification |
Shinigami92
added
the
p2-nice-to-have
Shinigami92
approved these changes
Sep 16, 2021
|
Optional: you could add a comment to the change for now, maybe we want to support RTL later. Who knows. |
|
This is the current behavior: But must be: |
patak-dev
approved these changes
Sep 16, 2021
|
Do tools like terminals normally include an option to set your preference to RTL? Is this something that we should add to Vite? |
For clarification, we set that manually, No there is no any option to do that in terminal tools. |
|
This is going to be released next Monday as part of the 2.6.0-beta.0 |
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make overlay window readable(Force it in LTR) in RTL development environment.
Description
In RTL develop environment the whole overlay direction and text-align is in RTL and right to left. which make it har to read!