Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use pkgId to get relative path (#4957) #4961

Merged
merged 1 commit into from Sep 17, 2021
Merged

fix: use pkgId to get relative path (#4957) #4961

merged 1 commit into from Sep 17, 2021

Conversation

meixg
Copy link
Contributor

@meixg meixg commented Sep 17, 2021 •
edited

Description

solve #4957

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 linked an issue Sep 17, 2021 that may be closed by this pull request
resolveDeepImport does not support aliased packages #4957
Closed
7 tasks
@Shinigami92 Shinigami92 self-requested a review September 17, 2021 09:47
@Shinigami92 Shinigami92 added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Sep 17, 2021
@patak-dev
Copy link
Member

Thanks for the fix @meixg, merging after testing locally. If you would like to keep collaborating, it would be good to have another PR that adds a test case for this. See https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#extending-the-test-suite

@patak-dev patak-dev merged commit b9e837a into vitejs:main Sep 17, 2021
meixg added a commit to meixg/vite that referenced this pull request Nov 4, 2021
@meixg
test: use pkgId to get relative path (fix vitejs#4957) (vitejs#4961)
2c0b0ab
@meixg meixg mentioned this pull request Nov 4, 2021
Merged
9 tasks
@meixg
Copy link
Contributor Author

meixg commented Nov 4, 2021

Thanks for the fix @meixg, merging after testing locally. If you would like to keep collaborating, it would be good to have another PR that adds a test case for this. See https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md#extending-the-test-suite

@patak-js I just added a test case for this PR, see #5549

patak-dev pushed a commit that referenced this pull request Nov 4, 2021
@meixg
test: add case for #4961 (#5549)
baa8c39
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@meixg @aleclarson
fix: use pkgId to get relative path (vitejs#4957) (vitejs#4961)
2c21c42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resolveDeepImport does not support aliased packages
3 participants
@meixg @patak-dev @Shinigami92