Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump js parser ecmaVersion option to 'latest', fix #5013 #5021

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Sep 22, 2021

Description

Fix #5013

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Sep 22, 2021
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing it to latest?

And there are several other occurrences of ecmaVersion in the code base, shall we fix them too?

@ygj6
Copy link
Member Author

ygj6 commented Sep 22, 2021

How about changing it to latest?

And there are several other occurrences of ecmaVersion in the code base, shall we fix them too?

LGTM. I am willing to modify

@patak-dev
Copy link
Member

+1 for both

@ygj6 ygj6 changed the title fix: enable latest syntax when parsing for ssr, fix #5013 fix: modify JavaScript parser's ecmaVersion option to 'latest', fix #5013 Sep 22, 2021
@patak-dev patak-dev changed the title fix: modify JavaScript parser's ecmaVersion option to 'latest', fix #5013 fix: bump js parser ecmaVersion option to 'latest', fix #5013 Sep 22, 2021
@patak-dev patak-dev merged commit 3541ebc into vitejs:main Sep 22, 2021
@ygj6 ygj6 deleted the issue-5013 branch September 23, 2021 01:22
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level await is not supported by ssrLoadModule
3 participants