Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support .astro files #5038

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Sep 22, 2021

Description

Adds ability for Vite to scan .astro files for dependencies. Doesn’t affect default behavior of scanning (.astro files aren’t scanned by default). Requires optimizeDeps: { entries: '**/*.astro' } to opt in.

Additional context

Should I add a playground example? Should I add playground + tests?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@drwpow drwpow force-pushed the feat/astro-entries branch 2 times, most recently from 27e0838 to 1947418 Compare September 22, 2021 21:41
@patak-dev
Copy link
Member

This looks good @drwpow, we don't need tests or to add a playground for this particular change 👍🏼

@patak-dev
Copy link
Member

I'll merge this one as it was already discussed with the team.

@patak-dev patak-dev changed the title feat: Add ability to scan .astro files for dependencies feat: support .astro files Sep 22, 2021
@patak-dev patak-dev merged commit 79ff0ec into vitejs:main Sep 22, 2021
@drwpow drwpow deleted the feat/astro-entries branch October 29, 2021 01:12
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants