fix(ssr): handle default arguments properly in ssrTransform
#5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any Identifier nodes that were both (1) used in a default argument expression and (2) referenced an import binding would not be rewritten to point to the transformed import binding.
For example:
```ts
import Foo from './foo'
export function hello(arg = Foo.foo) {}
```
…would be transformed into something like:
```ts
const __vite_ssr_import_0__ = __vite_ssr_import__('./foo')
function hello(arg = Foo.foo) {}
Object.defineProperty(__vite_ssr_exports__, "hello", { enumerable: true, value: hello })
```
…so the `Foo.foo` reference would result in a runtime error.
Shinigami92
approved these changes
Sep 23, 2021
patak-dev
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any Identifier nodes that were both (1) used in a default argument expression and (2) referenced an import binding would not be rewritten to point to the transformed import binding.
For example:
…would be transformed into something like:
…so the
Foo.fooreference would result in a runtime error.