Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance is not defined #5048

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix: performance is not defined #5048

merged 1 commit into from
Sep 23, 2021

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Sep 23, 2021

Description

fix the error:

global.__vite_start_time = performance.now()
                           ^

ReferenceError: performance is not defined
    at Object.<anonymous> (/Users/projectPath/node_modules/vite/bin/vite.js:10:28)
    at Module._compile (internal/modules/cjs/loader.js:1072:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
    at Module.load (internal/modules/cjs/loader.js:937:32)
    at Function.Module._load (internal/modules/cjs/loader.js:778:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 20b20e4 into vitejs:main Sep 23, 2021
@yyx990803
Copy link
Member

Dang, when I checked Node.js docs the global performance object has no "Added in vx.x.x" tag, so I assumed it has always been there... turns out it's only made a global in Node 16.

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants