Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.minify config for library mode is invalid #5451

Closed
7 tasks done
lixiangio opened this issue Oct 27, 2021 · 1 comment
Closed
7 tasks done

build.minify config for library mode is invalid #5451

lixiangio opened this issue Oct 27, 2021 · 1 comment

Comments

@lixiangio
Copy link

lixiangio commented Oct 27, 2021

Describe the bug

After upgrading vite, the build.minify configuration is invalid, minify is disabled in lib mode, and it was available before. This configuration is confusing, I found the reason, I hope to keep this feature, it is very useful to me. I don't want to write an additional Rollup plugin for this requirement, I hope there are other simple solutions.
vuejs/core#2860 (comment)
06d86e4

Reproduction

// vite config
{
  "build": {
    "minify": true,
    "lib": {
      "name": 'vue',
      "entry": 'vue.js',
      "formats": ['es'],
      "fileName": () => `vue.js`,
    }
  },
}

System Info

System:
    OS: Linux 5.4 Ubuntu 21.10 LTS
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
  Browsers:
    Chrome: 95.0.4638.54
  npmPackages:
    @vitejs/plugin-vue: ^1.9.3 => 1.9.3 
    vite: ^2.6.4

Used Package Manager

pnpm

Logs

No response

Validations

@Niputi
Copy link
Contributor

Niputi commented Oct 27, 2021

duplicate of #5167

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants