Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in @vitejs/plugin-legacy breaks manifest.json path to vite/legacy-polyfills #6097

Closed
7 tasks done
portfolioris opened this issue Dec 13, 2021 · 1 comment · Fixed by #6225
Closed
7 tasks done

Comments

@portfolioris
Copy link

Describe the bug

The key in manifest.json vite/legacy-polyfills has changed to \0000vite/legacy-polyfills. I am unable to read that key.

My guess it has something to with this change: https://github.com/vitejs/vite/pull/5601/files#diff-e861d33a288ea61b3aee05203d1c43920c4326d904e3d41b4326adbd30a0127fR599

Reproduction

Vite config:

import legacy from '@vitejs/plugin-legacy';
import { defineConfig } from 'vite';

export default defineConfig({
  build: {
    manifest: true,
  },
  plugins: [
    legacy(),
  ],
});

Run vite build.

Check dist/manifest.json.

System Info

System:
    OS: macOS 12.0.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 34.61 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.1/bin/npm
  Browsers:
    Edge: 96.0.1054.53
    Firefox: 94.0.1
    Firefox Developer Edition: 96.0
    Safari: 15.1
  npmPackages:
    @vitejs/plugin-legacy: ^1.6.4 => 1.6.4 
    vite: ^2.7.1 => 2.7.1

Used Package Manager

npm

Logs

No response

Validations

@jasondibenedetto
Copy link

We have been running into this issue as well, was unsure if it was a Vite specific issue or something that needs to be updated in the framework we are using (https://github.com/nystudio107/craft-vite)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants