feat(config): hmr add disable port config

[jeoy]

Description

HMR connecting failed when I have to config a hmr port or using default port.

Unexpected socket host: www.mydomain.com:3000
Expected socket host: www.mydomain.com

Using default port cannot solve this problem completely when I need both http(80) and https(443) domain to access.

Adding a custom hmr host config is not a perfect solution, cause I have to config different hmr host for every project.

So, I was wondering if we can add disable port config for this situation?

Solution 1:
Change port: number -> port: number | false.

Solution 2:
add new config: disablePort: boolean (default false)

below is changes of Solution 1.

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• [ x Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[jeoy]

CI failed caused by this line

code.replace should be code.replaceAll for an injected global var used more than once

`

[bluwy]

below is changes of Solution 1.

Looks like the changes now are Solution 2 though. I think Solution 1 seems nicer to avoid another option.

[jeoy]

yeah... but solution 1 make type of port a bit weird, don't you think?
Another option seems to in conformity with the SRP.

[jeoy]

below is changes of Solution 1.

Looks like the changes now are Solution 2 though. I think Solution 1 seems nicer to avoid another option.

Hi @bluwy , please review again when you convenient, thanks!

[patak-dev]

I also think that solution 1, port: number -> port: number | false is better here

[jeoy]

I also think that solution 1, port: number -> port: number | false is better here

Sure, now is solution 1 already.

[bluwy]

Nice! Thanks for making the change.

[patak-dev]

We'll discuss it in the next meeting to validate the API change. Thanks @jeoy!

[patak-dev]

We are good to merge this PR, let's do it in the 2.9 beta (we should start it soon)

[bluwy]

I think we should update the types in the docs too.

[jeoy]

rebase main branch and resolve conflict

[bluwy]

This LGTM with one more update to the docs at https://vitejs.dev/config/#server-hmr

[jeoy]

This LGTM with one more update to the docs at https://vitejs.dev/config/#server-hmr

Docs updated.