Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .js suffix to /vite/client #714

Closed
cztomsik opened this issue Aug 17, 2020 · 2 comments
Closed

add .js suffix to /vite/client #714

cztomsik opened this issue Aug 17, 2020 · 2 comments

Comments

@cztomsik
Copy link

Description

It's already possible to use vite from deno (import 'http://localhost:3000/src/main.jsx' for example). You only need to provide your own DOM & WebSocket impl but so far it works really great.

The only issue is that Deno thinks vite/client is TypeScript file (because it doesn't have .js suffix) and so it tries to do type-checking. It works with --no-check but I think there's no big reason why vite/client cannot have suffix (like other files in there) and play nice with others so I suggest adding it.

It should be very simple to fix (I have a PR already but it's failing and I'm not sure what's broken in there)

I did the change in my local node_modules and it worked fine so that's why I'm puzzled what's the issue.

System Info

  • required vite version: 1.0.0-rc.4
  • required Operating System: OSX
  • required Node version: node v12; deno 1.3.0

Err in CircleCI

image

@yyx990803
Copy link
Member

yyx990803 commented Jan 8, 2021

I'm not sure what this is trying to achieve and I have no idea why vite/client would need to be loaded in deno since it's a client-only file. This is also likely stale for 2.0. Either way, Vite currently has no plan for Deno support.

@cztomsik
Copy link
Author

cztomsik commented Mar 18, 2021

  • this was about running vite runtime in deno (jsdom-like use-case), original motivation was this lightweight dom-like engine
  • it works already (or at least it definitely did few weeks ago) without any changes

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants