Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin-vue): remove querystring import #7997

Merged
merged 1 commit into from May 3, 2022
Merged

refactor(plugin-vue): remove querystring import #7997

merged 1 commit into from May 3, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 3, 2022

Description

The querystring module is deprecated in nodejs, use URLSearchParams and encodeUriComponent instead. Both are available in node 10

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added plugin: vue p1-chore Doesn't change code behavior (priority) labels May 3, 2022
@patak-dev patak-dev merged commit f3d15f1 into vitejs:main May 3, 2022
@bluwy bluwy deleted the vue-no-querystring branch May 3, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@poyoho poyoho poyoho approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bluwy @patak-dev @poyoho