legacy-plugin forces minify (still)

[phil294]

Describe the bug

Very similar to #6266, but this is apparently not fixed yet. legacy does sometimes not respect minify:false and also assetFileNames. With

  plugins: [legacy()],
  build: {
    rollupOptions: {
      output: {
        entryFileNames: '[name].js',
        chunkFileNames: '[name].js',
        assetFileNames: 'assets/[name][extname]',
      },
    },
    minify: false,
  }

the following happens in dist (run npm install && npm run build in the stackblitz repro below):

FILENAME                                 IS MINIFIED      HASHED FILENAME
index.js                                 no               no
index-legacy.js                          yes (ERROR)      no
assets/polyfills-legacy.4ca31241.js      no               yes (ERROR)

See the two ERRORs.

Motivation: Build a VSCode Extension WebView using Vue.js without minification. Here, you need to craft the index.html by hand, that's why the hashes are problematic too.

I realize this is a rather exotic setup and I'll just switch to Webpack for this now, but hopefully this report will help you.

Reproduction

https://stackblitz.com/edit/vitejs-vite-5abiav?file=vite.config.js

System Info

npx envinfo --system --npmPackages '{vite,@vitejs/*}' --binaries --browsers does not output anything on stackblitz, you might want to check that :/ it's a neverending loading ticking cursor.

Anyway, it's

    "@vitejs/plugin-legacy": "^1.8.2",
    "vite": "^2.9.9"

on both stackblitz and local x64 Manjaro Linux. Browser does not play a role here.

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

About assets/polyfills-legacy.4ca31241.js, it is a duplicate of #4221.