docs: correct pnpm command #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions provided for scaffolding a template in pnpm do you set the template as expected. The extra double-dash is not needed in pnpm 7. - `pnpm create vite -- --template vue` <-- asks to select framework - `pnpm create vite --template vue` <-- correctly sets framework without prompting.
✅ Deploy Preview for vite-docs-main canceled.
|
|
Good catch! Would be great to update https://github.com/vitejs/vite/blob/main/packages/create-vite/README.md too |
patak-dev
approved these changes
Jun 24, 2022
patak-dev
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the pnpm getting started example. The instructions provided for scaffolding a template in pnpm do not set the template as expected. The extra double-dash is not needed in pnpm 7.
pnpm create vite -- --template vue<-- will prompt to select frameworkpnpm create vite --template vue<-- correctly sets framework without prompting.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).