Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate dep with hash and without #9661

Closed
7 tasks done
Akryum opened this issue Aug 13, 2022 · 1 comment
Closed
7 tasks done

Duplicate dep with hash and without #9661

Akryum opened this issue Aug 13, 2022 · 1 comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization pending triage

Comments

@Akryum
Copy link
Contributor

Akryum commented Aug 13, 2022

Describe the bug

Actual

The @histoire/vendors dep files are loaded into the page twice, one time without hash and one time with an hash.

image
image

Expected

The files are loaded once.

image

Reproduction

https://github.com/Akryum/vite-issue-duplicate-dep

System Info

System:
    OS: Linux 5.18 Fedora Linux 36 (Workstation Edition)
    CPU: (24) x64 AMD Ryzen 9 3900XT 12-Core Processor
    Memory: 37.38 GB / 62.71 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.16.0/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 103.0.1
  npmPackages:
    vite: ^3.0.7 => 3.0.7

Used Package Manager

pnpm

Logs

No response

Validations

@sapphi-red
Copy link
Member

This seems to be already fixed in at least 3.2.7.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: deps optimizer Esbuild Dependencies Optimization pending triage
Projects
None yet
Development

No branches or pull requests

3 participants