Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromDict Should Handle Data Types with no URL #54

Closed
ilan-gold opened this issue Mar 16, 2021 · 2 comments · Fixed by #115
Closed

fromDict Should Handle Data Types with no URL #54

ilan-gold opened this issue Mar 16, 2021 · 2 comments · Fixed by #115

Comments

@ilan-gold
Copy link
Collaborator

# Add each dataset from the incoming config.
for d in config["datasets"]:
new_dataset = vc.add_dataset(uid=d["uid"], name=d["name"])
for f in d["files"]:
new_file = new_dataset.add_file(
url=f["url"],
data_type=f["type"],
file_type=f["fileType"]
)

The above requires that the file object contains a url which is not necessarily true, for example, for raster data which have options not `url.

@ilan-gold
Copy link
Collaborator Author

Needed for (or at least a use case could be made for using this in): https://github.com/hubmapconsortium/portal-ui/tree/ilan-gold/initial_z_stack

@ngehlenborg
Copy link
Member

ngehlenborg commented Jan 20, 2022

Will likely be addressed by #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants