Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin] Remove link to vtctld web #15597

Closed
notfelineit opened this issue Mar 29, 2024 · 2 comments
Closed

[vtadmin] Remove link to vtctld web #15597

notfelineit opened this issue Mar 29, 2024 · 2 comments
Projects
VTAdmin

Comments

@notfelineit
Copy link
Contributor

I think we're still linking to vtctld web from vtadmin's vtctld page: https://github.com/vitessio/vitess/blob/main/web/vtadmin/src/components/routes/Vtctlds.tsx#L54-L57

vtctld web was deprecated in v17 I believe, so we should remove these links.
@notfelineit notfelineit created this issue from a note in VTAdmin (To do soon-ish (planned but not started)) Mar 29, 2024
@shlomi-noach
Copy link
Contributor

Related: #15587

@javamyth javamyth mentioned this issue Apr 1, 2024
Open
@notfelineit notfelineit mentioned this issue Apr 2, 2024
Merged
5 tasks
@notfelineit
Copy link
Contributor Author

Completed in #15607

VTAdmin automation moved this from To do soon-ish (planned but not started) to Done Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
VTAdmin
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shlomi-noach @notfelineit