Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Vitess provide a vtgate queries metric by tablet type #16391

Open
jwangace opened this issue Jul 15, 2024 · 2 comments
Open

Comments

@jwangace
Copy link
Contributor

Feature Description

Vtgate has metrics:

vtgate_queries_processed
vtgate_queries_routed

But those metrics does not distinguish queries by tablet type(RRIMARY, REPLICA), it would be great to have break down metrics, for example:

vtgate_queries_processed_primary
vtgate_queries_processed_replica
vtgate_queries_routed_primary
vtgate_queries_routed_replica

Use Case(s)

This will provide user better ideas of queries to which type of tables are sent.

@jwangace jwangace added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature Request labels Jul 15, 2024
@mattlord mattlord added Component: Query Serving and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jul 15, 2024
@mattlord
Copy link
Contributor

/cc @vitessio/query-serving

@deepthi
Copy link
Member

deepthi commented Jul 16, 2024

If we decide to do this, we should add a dimension to vtgate_queries_processed to represent tablet_type. We would not want to duplicate the metric for every serving tablet type of which we have more than two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants