Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Comment handling in vitess #7580

Closed
GuptaManan100 opened this issue Mar 2, 2021 · 0 comments · Fixed by #7581
Closed

Incorrect Comment handling in vitess #7580

GuptaManan100 opened this issue Mar 2, 2021 · 0 comments · Fixed by #7581
Assignees
@GuptaManan100
Labels
Component: Query Serving Type: Bug

Comments

@GuptaManan100
Copy link
Member

Overview of the Issue

Vitess treats everything after -- as a comment while MySQL treats everything after -- as a comment. (Notice the space). This means that the query SET @S = --4 is valid on MySQL but Vitess throws a parsing error.

Reproduction Steps

The issue can be reproduced by adding a test case to the parser tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuptaManan100 GuptaManan100

Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrects the comment handling in vitess GuptaManan100/vitess
2 participants
@askdba @GuptaManan100